Skip to content

Styling fixes#265

Merged
GabrielAnca merged 2 commits into
masterfrom
ga/fix-styling
Sep 4, 2018
Merged

Styling fixes#265
GabrielAnca merged 2 commits into
masterfrom
ga/fix-styling

Conversation

@GabrielAnca

Copy link
Copy Markdown
Contributor

Multiple styling fixes ✨

  • Fix readme to fit PSR-2 (4 spaces indentation)
  • Add ext-json in the composer.json as it is required for json_decode.
  • Fix some PHPDocs that were missing stuff, had typos or were missing.
  • Remove unused imports
  • Add the $visitors class variable to IntercomClient. It was missing, but due to PHP's magic, it was created on the fly by the constructor.

All credits go to PHPStorm ©️

My next step is to check for broken links in the PHPDoc blocks and fix PSR2 in the tests to be able to add linting to the build 😄

@SeanHealy33 SeanHealy33 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📑

@GabrielAnca
GabrielAnca merged commit 708e514 into master Sep 4, 2018
@GabrielAnca
GabrielAnca deleted the ga/fix-styling branch September 4, 2018 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants