This repository was archived by the owner on Apr 23, 2026. It is now read-only.
ci: Don't require security-lint for auto-merge#3353
Closed
booxter wants to merge 1 commit intoinstructlab:mainfrom
Closed
ci: Don't require security-lint for auto-merge#3353booxter wants to merge 1 commit intoinstructlab:mainfrom
booxter wants to merge 1 commit intoinstructlab:mainfrom
Conversation
The check has known false positives [1], so we cannot make it a requirement for mergify. It's an informational signal for reviewers that additional scrutiny may be justified. [1]: instructlab/ci-actions#14 (comment) Signed-off-by: Ihar Hrachyshka <[email protected]>
5 tasks
Contributor
Author
|
Unblocking this to allow merging; I believe this is the right thing to do, knowing that the check is designed to trigger false positives, and so it cannot be used as a merge requirement and/or block running other jobs. |
6 tasks
Contributor
Author
|
Maybe I won't need after all if I get away without GH_TOKEN (that may not be needed for just checking out the current PR from git.) |
Contributor
|
I am ok with this, based on my analysis in instructlab/ci-actions#14 Agreed it would be great to remove our use of |
ktdreyer
approved these changes
May 8, 2025
Contributor
Author
|
I don't have capacity to complete it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check has known false positives 1, so we cannot make it a
requirement for mergify. It's an informational signal for reviewers that
additional scrutiny may be justified.
Signed-off-by: Ihar Hrachyshka [email protected]
Checklist:
conventional commits.