Skip to content
This repository was archived by the owner on Apr 23, 2026. It is now read-only.

chore(deps): Bump minimum instructlab-training version#3312

Merged
mergify[bot] merged 1 commit intomainfrom
update-training-version
Apr 30, 2025
Merged

chore(deps): Bump minimum instructlab-training version#3312
mergify[bot] merged 1 commit intomainfrom
update-training-version

Conversation

@courtneypacheco
Copy link
Copy Markdown
Contributor

@courtneypacheco courtneypacheco commented Apr 23, 2025

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.

Ensure that the latest version for instructlab-training is consumed: https://github.com/instructlab/training/releases/tag/v0.10.1

@courtneypacheco courtneypacheco marked this pull request as ready for review April 23, 2025 13:58
@mergify mergify Bot added dependencies Relates to dependencies ci-failure PR has at least one CI failure labels Apr 23, 2025
@courtneypacheco courtneypacheco force-pushed the update-training-version branch from 0883288 to 25f305d Compare April 23, 2025 14:54
@courtneypacheco courtneypacheco marked this pull request as draft April 23, 2025 14:54
@mergify mergify Bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Apr 23, 2025
@courtneypacheco courtneypacheco force-pushed the update-training-version branch from 25f305d to dd30632 Compare April 23, 2025 16:24
@mergify mergify Bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Apr 23, 2025
@courtneypacheco courtneypacheco force-pushed the update-training-version branch from dd30632 to a98b82b Compare April 23, 2025 19:52
@mergify mergify Bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Apr 23, 2025
@courtneypacheco courtneypacheco force-pushed the update-training-version branch from a98b82b to 178c62c Compare April 23, 2025 20:41
@mergify mergify Bot removed the ci-failure PR has at least one CI failure label Apr 23, 2025
@courtneypacheco courtneypacheco force-pushed the update-training-version branch from 178c62c to d969b58 Compare April 23, 2025 20:43
@mergify mergify Bot added the ci-failure PR has at least one CI failure label Apr 23, 2025
@ktdreyer
Copy link
Copy Markdown
Contributor

ktdreyer commented Apr 24, 2025

The e2e-medium tests consistently fail with this PR.

We also identified that e2e is failing on the training repo itself, instructlab/training#494

@courtneypacheco courtneypacheco force-pushed the update-training-version branch from d969b58 to b3e2d35 Compare April 24, 2025 18:57
@mergify mergify Bot removed the ci-failure PR has at least one CI failure label Apr 24, 2025
@courtneypacheco courtneypacheco force-pushed the update-training-version branch from b3e2d35 to 3f5cabc Compare April 24, 2025 18:58
@mergify mergify Bot added the ci-failure PR has at least one CI failure label Apr 24, 2025
@ktdreyer
Copy link
Copy Markdown
Contributor

ktdreyer commented Apr 28, 2025

e2e-medium CI fails with:

/actions-runner/_work/instructlab/instructlab/venv/lib64/python3.11/site-packages/flash_attn_2_cuda.cpython-311-x86_64-linux-gnu.so: undefined symbol: _ZN3c105ErrorC2ENS_14SourceLocationENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE

We've triaged this failure to #3320

@ktdreyer ktdreyer added this to the 0.26.0 milestone Apr 28, 2025
@ktdreyer
Copy link
Copy Markdown
Contributor

ktdreyer commented Apr 28, 2025

@Mergifyio rebase

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 28, 2025

rebase

✅ Branch has been successfully rebased

@ktdreyer ktdreyer force-pushed the update-training-version branch from 3f5cabc to cedaf89 Compare April 28, 2025 21:46
@mergify mergify Bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Apr 28, 2025
@booxter
Copy link
Copy Markdown
Contributor

booxter commented Apr 28, 2025

I think every minimal version bump should at least attempt to explain why it's needed.

@cdoern
Copy link
Copy Markdown
Contributor

cdoern commented Apr 30, 2025

@Mergifyio rebase

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 30, 2025

rebase

✅ Branch has been successfully rebased

@cdoern cdoern force-pushed the update-training-version branch from cedaf89 to 07a81ce Compare April 30, 2025 12:28
@mergify mergify Bot removed the ci-failure PR has at least one CI failure label Apr 30, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 30, 2025

E2E (NVIDIA L40S x4) workflow launched on this PR: View run

@cdoern cdoern marked this pull request as ready for review April 30, 2025 12:39
@cdoern cdoern force-pushed the update-training-version branch from 07a81ce to 089fa33 Compare April 30, 2025 12:43
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 30, 2025

E2E (NVIDIA L40S x4) workflow launched on this PR: View run

@mergify mergify Bot added the ci-failure PR has at least one CI failure label Apr 30, 2025
@courtneypacheco @cdoern
chore(deps): Bump minimum instructlab-training version
5b56fca 
Ensure that the latest version for `instructlab-training` is consumed: https://github.com/instructlab/training/releases/tag/v0.10.1

Signed-off-by: Courtney Pacheco <[email protected]>
Signed-off-by: Charlie Doern <[email protected]>
@cdoern cdoern force-pushed the update-training-version branch from 089fa33 to 5b56fca Compare April 30, 2025 13:25
@mergify mergify Bot removed the ci-failure PR has at least one CI failure label Apr 30, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 30, 2025

E2E (NVIDIA L40S x4) workflow launched on this PR: View run

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 30, 2025

e2e workflow succeeded on this PR: View run, congrats!

@cdoern
Copy link
Copy Markdown
Contributor

cdoern commented Apr 30, 2025

@Mergifyio backport

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 30, 2025 •
edited
Loading

backport

❌ No backport have been created

Details

No destination branches found

@mergify mergify Bot added the one-approval PR has one approval from a maintainer label Apr 30, 2025
@courtneypacheco courtneypacheco removed the request for review from RobotSail April 30, 2025 16:37
@ktdreyer ktdreyer self-requested a review April 30, 2025 16:57
ktdreyer
ktdreyer reviewed Apr 30, 2025
View reviewed changes
Comment thread constraints-dev.txt

torch<2.7.0
vllm<0.9.0
vllm<0.9.0 No newline at end of file
Copy link
Copy Markdown
Contributor

@ktdreyer ktdreyer Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably changing this line because it has the string "0.9.0" here, and the editor altered the newline on this file.

@mergify mergify Bot merged commit 4577884 into main Apr 30, 2025
27 checks passed
@mergify mergify Bot removed the one-approval PR has one approval from a maintainer label Apr 30, 2025
@mergify mergify Bot deleted the update-training-version branch April 30, 2025 17:00
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 30, 2025

e2e workflow succeeded on this PR: View run, congrats!

@cdoern
Copy link
Copy Markdown
Contributor

cdoern commented Apr 30, 2025

https://github.com/Mergifyio backport release-v0.26

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 30, 2025 •
edited
Loading

backport release-v0.26

✅ Backports have been created

Details

@mergify mergify Bot mentioned this pull request Apr 30, 2025
Closed
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ktdreyer ktdreyer ktdreyer approved these changes

@cdoern cdoern cdoern approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Relates to dependencies

Projects

None yet

Milestone

0.26.0

Development

Successfully merging this pull request may close these issues.

4 participants

@courtneypacheco @ktdreyer @booxter @cdoern