Skip to content
This repository was archived by the owner on Apr 23, 2026. It is now read-only.

fix: respect global teacher id for generation (backport #3309)#3311

Merged
mergify[bot] merged 1 commit intorelease-v0.26from
mergify/bp/release-v0.26/pr-3309
Apr 23, 2025
Merged

fix: respect global teacher id for generation (backport #3309)#3311
mergify[bot] merged 1 commit intorelease-v0.26from
mergify/bp/release-v0.26/pr-3309

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Apr 23, 2025

missed adding logic to pick up teacher model id from config in earlier PR. This PR fixes that

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.
This is an automatic backport of pull request #3309 done by [Mergify](https://mergify.com).

@jaideepr97 @mergify
respect global teacher id for generation
6ea33e2 
Signed-off-by: Jaideep Rao <[email protected]>
(cherry picked from commit 8ea9979)
@mergify mergify Bot mentioned this pull request Apr 23, 2025
Merged
6 tasks
@mergify mergify Bot added the release-branch Pull Request directly to a release branch label Apr 23, 2025
@mergify mergify Bot added one-approval PR has one approval from a maintainer ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Apr 23, 2025
@mergify mergify Bot merged commit efd9ddc into release-v0.26 Apr 23, 2025
28 checks passed
@mergify mergify Bot removed the one-approval PR has one approval from a maintainer label Apr 23, 2025
@mergify mergify Bot deleted the mergify/bp/release-v0.26/pr-3309 branch April 23, 2025 12:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@courtneypacheco courtneypacheco courtneypacheco approved these changes

@jaideepr97 jaideepr97 jaideepr97 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-branch Pull Request directly to a release branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@courtneypacheco @jaideepr97