This repository was archived by the owner on Apr 23, 2026. It is now read-only.
Fix floating ip add for ibm cloud#3310
Merged
mergify[bot] merged 1 commit intoinstructlab:mainfrom Apr 23, 2025
danmcp:floatingip
Merged
Fix floating ip add for ibm cloud#3310mergify[bot] merged 1 commit intoinstructlab:mainfrom danmcp:floatingip
mergify[bot] merged 1 commit intoinstructlab:mainfrom
danmcp:floatingip
Conversation
There was an extra INSTANCE_NAME being passed so the command would only work if the instance name and floating ip names were the same. Co-authored-by: RobotSail <[email protected]> Signed-off-by: Dan McPherson <[email protected]>
RobotSail
approved these changes
Apr 23, 2025
courtneypacheco
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an extra INSTANCE_NAME being passed so the command would only work if the instance name and floating ip names were the same.
Credit to @RobotSail for finding the issue.
Checklist:
conventional commits.