This repository was archived by the owner on Apr 23, 2026. It is now read-only.
fix: respect global teacher id for generation#3309
Merged
mergify[bot] merged 1 commit intoinstructlab:mainfrom Apr 23, 2025
Merged
fix: respect global teacher id for generation#3309mergify[bot] merged 1 commit intoinstructlab:mainfrom
mergify[bot] merged 1 commit intoinstructlab:mainfrom
Conversation
Signed-off-by: Jaideep Rao <[email protected]>
cdoern
approved these changes
Apr 23, 2025
Contributor
|
@mergify backport release-v0.26 |
Contributor
✅ Backports have been createdDetails
|
6 tasks
mergify Bot
added a commit
that referenced
this pull request
Apr 23, 2025
missed adding logic to pick up teacher model id from config in earlier PR. This PR fixes that **Checklist:** - [ ] **Commit Message Formatting**: Commit titles and messages follow guidelines in the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/#summary). - [ ] [Changelog](https://github.com/instructlab/instructlab/blob/main/CHANGELOG.md) updated with breaking and/or notable changes for the next minor release. - [ ] Documentation has been updated, if necessary. - [ ] Unit tests have been added, if necessary. - [ ] Functional tests have been added, if necessary. - [ ] E2E Workflow tests have been added, if necessary. <hr>This is an automatic backport of pull request #3309 done by [Mergify](https://mergify.com). Approved-by: courtneypacheco Approved-by: jaideepr97
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
missed adding logic to pick up teacher model id from config in earlier PR. This PR fixes that
Checklist:
conventional commits.