Preserve storage after e2e tests#3303
Preserve storage after e2e tests#3303mergify[bot] merged 1 commit intoinstructlab:mainfrom danmcp:gguf
Conversation
mergify
Bot
added
CI/CD
danmcp
changed the title
mergify
Bot
added
ci-failure
danmcp
changed the title
There really isn't a reason to delete it and knowing the size after the tests is helpful to understand how large of a disk is needed. Signed-off-by: Dan McPherson <[email protected]>
|
@danmcp would you mind explaining a bit more about how you're testing this? The GH Action will delete the node as soon as the e2e script completes, right? Are you doing something behind the scenes to avoid deleting the node? |
The change is useful because we print out the usage after the test is run. Example:
Currently we delete the test results then delete the node immediately after. That makes it so reporting the disks after the tests isn't helpful to determine how much disk was needed. To test, I simply ran the script with the parameter to prove it works. We won't see the actual numbers until it merges since the workflows don't take effect with pull request target. |
|
Oh, got it! This would be faster as well, then. |
4 participants
Updating to get a better idea over time how much storage is being used and the storage isn't needed after the test
Checklist:
conventional commits.