This repository was archived by the owner on Apr 23, 2026. It is now read-only.
feat: Handle lists of pydantic models when dumping to yaml#3295
Merged
mergify[bot] merged 1 commit intoinstructlab:mainfrom Apr 18, 2025
Merged
Conversation
6 tasks
Contributor
Author
|
jaideepr97
approved these changes
Apr 17, 2025
Contributor
jaideepr97
left a comment
jaideepr97
left a comment
There was a problem hiding this comment.
tested locally, works
LGTM, thanks @booxter
RobotSail
approved these changes
Apr 17, 2025
cdoern
approved these changes
Apr 17, 2025
Contributor
|
medium job seems to be failing consistently with storage issues that seem unrelated to PR changes |
mergify
Bot
added
ci-failure
|
E2E (NVIDIA L40S x4) LLAMA workflow launched on this PR: View run |
|
e2e workflow failed on this PR: View run, please investigate. |
Contributor
Author
|
@Mergifyio rebase |
Before the change, lists of models were not converted to dicts before passing them to ruamel representor. It broke `config show` when a `models` section was added to it because the field is s list of model_info classes. With this change, we should correctly handle tuples and lists. If we ever need something else, like dicts, we may expand the serialization code further. Signed-off-by: Ihar Hrachyshka <[email protected]>
Contributor
✅ Branch has been successfully rebased |
booxter
force-pushed
the
fix-config-dump-for-lists-of-models
branch
from
741944f to
dff86fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the change, lists of models were not converted to dicts before
passing them to ruamel representor. It broke
config showwhen amodelssection was added to it because the field is s list ofmodel_info classes.
With this change, we should correctly handle tuples and lists. If we
ever need something else, like dicts, we may expand the serialization
code further.
Signed-off-by: Ihar Hrachyshka [email protected]
Checklist:
conventional commits.