This repository was archived by the owner on Apr 23, 2026. It is now read-only.
pick up model id defaults from config yaml#3286
Merged
mergify[bot] merged 2 commits intoinstructlab:mainfrom Apr 14, 2025
Merged
pick up model id defaults from config yaml#3286mergify[bot] merged 2 commits intoinstructlab:mainfrom
mergify[bot] merged 2 commits intoinstructlab:mainfrom
Conversation
jaideepr97
force-pushed
the
add-global-model-id
branch
from
e347012 to
fffc671
Compare
cdoern
reviewed
Apr 11, 2025
| type=click.STRING, | ||
| show_default=True, | ||
| show_default=False, | ||
| config_class="general", |
Contributor
There was a problem hiding this comment.
idk if you need config_sections if its in the top level of general
Contributor
Author
There was a problem hiding this comment.
hmmm, doesnt seem to be making a difference either way
jaideepr97
force-pushed
the
add-global-model-id
branch
from
fffc671 to
533ed54
Compare
RobotSail
reviewed
Apr 11, 2025
| description="Use legacy IBM Granite chat template (default uses 3.0 Instruct template)", | ||
| ) | ||
| # Global student model id | ||
| student_model_id: str | None = Field( |
Member
There was a problem hiding this comment.
Try using typing.NotRequired here, we should see whether this type can allow us to avoid explicitly include this field within the config
Suggested change
| student_model_id: str | None = Field( | |
| student_model_id: typing.NotRequired[str] = Field( |
Member
There was a problem hiding this comment.
Specifically today all config fields will be rendered in the default on-disk config which is super confusing. I want to see if using this type will prevent this field from being listed there entirely until it's necessary.
Contributor
Author
There was a problem hiding this comment.
i dont think thats compatible with pydantic
The error "`NotRequired[] can be only used in a TypedDict definition`" is occurring because `typing.NotRequired` is being used in a `pydantic` model, which is not allowed. `NotRequired` is specifically designed for use in `TypedDict` definitions, not in `pydantic` models.
In your code, the problematic line is:
teacher_model_id: typing.NotRequired[str] = Field(
default_factory=lambda: None,
description="ID of the teacher model to be used for data generation.",
exclude=True,
)
---
### Why This is Happening
`pydantic` models use `Optional` or `default_factory` to define optional fields. The `NotRequired` type hint is not compatible with `pydantic` models because it is meant for `TypedDict` definitions.
Member
There was a problem hiding this comment.
@jaideepr97 I see, thank you for checking this. The way you have done it is perfect
jaideepr97
force-pushed
the
add-global-model-id
branch
from
533ed54 to
1484171
Compare
mergify
Bot
added
ci-failure
jaideepr97
force-pushed
the
add-global-model-id
branch
from
1484171 to
68bb5f6
Compare
mergify
Bot
added
ci-failure
Contributor
|
This pull request has merge conflicts that must be resolved before it can be merged. @jaideepr97 please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork |
jaideepr97
force-pushed
the
add-global-model-id
branch
from
68bb5f6 to
74d3d30
Compare
mergify
Bot
added
ci-failure
Signed-off-by: Jaideep Rao <[email protected]>
jaideepr97
force-pushed
the
add-global-model-id
branch
from
74d3d30 to
e6cc71e
Compare
RobotSail
approved these changes
Apr 14, 2025
Signed-off-by: Jaideep Rao <[email protected]>
cdoern
approved these changes
Apr 14, 2025
mergify
Bot
added
ci-failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow setting a global student and teacher model id in the config, which can be overridden by cmd args
Checklist:
conventional commits.