Skip to content
This repository was archived by the owner on Apr 23, 2026. It is now read-only.

Handle INSTANCE_ID and details support for IBM Cloud and add rename m…#3205

Merged
mergify[bot] merged 1 commit intoinstructlab:mainfrom
danmcp:cloud-instance
Mar 2, 2025
Merged

Handle INSTANCE_ID and details support for IBM Cloud and add rename m…#3205
mergify[bot] merged 1 commit intoinstructlab:mainfrom
danmcp:cloud-instance

Conversation

@danmcp
Copy link
Copy Markdown
Contributor

@danmcp danmcp commented Feb 28, 2025 •
edited
Loading

…ethod for ec2 and ibm

PR includes:

  • Adding INSTANCE_ID support for ibm cloud
    • Rename _get_instances to _get_ec2_instances since it is specific to ec2
  • Add details support for ibm cloud
  • Add rename support for ibm and ec2
  • Fix usage of EC2_INSTANCE_TYPE in launch echo

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.

booxter
booxter approved these changes Feb 28, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@booxter booxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed for EC2 it works. For IBM, only read the code and it seems to make sense.

@mergify mergify Bot added the one-approval PR has one approval from a maintainer label Feb 28, 2025
@mergify mergify Bot removed the one-approval PR has one approval from a maintainer label Mar 2, 2025
@danmcp danmcp removed the request for review from ktdreyer March 2, 2025 19:22
@mergify mergify Bot merged commit a248d2a into instructlab:main Mar 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@booxter booxter booxter approved these changes

@courtneypacheco courtneypacheco courtneypacheco approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danmcp @booxter @courtneypacheco