This repository was archived by the owner on Apr 23, 2026. It is now read-only.
Add option to search multiple subnets with cloud-instance launch#3201
Merged
mergify[bot] merged 1 commit intoinstructlab:mainfrom Feb 27, 2025
danmcp:cisubnets
Merged
Add option to search multiple subnets with cloud-instance launch#3201mergify[bot] merged 1 commit intoinstructlab:mainfrom danmcp:cisubnets
mergify[bot] merged 1 commit intoinstructlab:mainfrom
danmcp:cisubnets
Conversation
Signed-off-by: Dan McPherson <[email protected]>
courtneypacheco
approved these changes
Feb 27, 2025
booxter
reviewed
Feb 27, 2025
Contributor
booxter
left a comment
There was a problem hiding this comment.
One question about the interface.
booxter
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds new optional config to cloud-instance for letting
cloud-instance.sh ec2 launchsearch for an instance type across multiple subnets for an available instance. Example of the new config:So if you were looking for a g6e.12xlarge, it would first look in subnet-12345678901234567, if an available instance wasn't found there, it would then look in subnet-12345678901234568. If still no instance was found it would fail.
Checklist:
conventional commits.