This repository was archived by the owner on Apr 23, 2026. It is now read-only.
feat(infra): add -i option for instance id to cloud-instance.sh#3199
Merged
mergify[bot] merged 1 commit intoinstructlab:mainfrom Feb 28, 2025
Merged
feat(infra): add -i option for instance id to cloud-instance.sh#3199mergify[bot] merged 1 commit intoinstructlab:mainfrom
mergify[bot] merged 1 commit intoinstructlab:mainfrom
Conversation
Contributor
Author
|
Will open for review once #3198 is merged and I rebase. |
It was possible to set INSTANCE_ID= envvar; but it was awkward. An option seems to be better UX to me. Signed-off-by: Ihar Hrachyshka <[email protected]>
booxter
force-pushed
the
add-i-option
branch
from
a4eee91 to
99dd50a
Compare
danmcp
approved these changes
Feb 28, 2025
courtneypacheco
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
conventional commits.