Skip to content
This repository was archived by the owner on Apr 23, 2026. It is now read-only.

docs: Add DK-Bench docs#3124

Merged
mergify[bot] merged 1 commit intoinstructlab:mainfrom
alimaredia:dk-bench-docs
Mar 6, 2025
Merged

docs: Add DK-Bench docs#3124
mergify[bot] merged 1 commit intoinstructlab:mainfrom
alimaredia:dk-bench-docs

Conversation

@alimaredia
Copy link
Copy Markdown
Contributor

@alimaredia alimaredia commented Feb 5, 2025

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.

@alimaredia alimaredia marked this pull request as ready for review February 5, 2025 13:05
@mergify mergify Bot added CI/CD Affects CI/CD configuration documentation Improvements or additions to documentation ci-failure PR has at least one CI failure labels Feb 5, 2025
@alimaredia alimaredia force-pushed the dk-bench-docs branch 2 times, most recently from 824a0c4 to 1f7c248 Compare February 5, 2025 13:24
@mergify mergify Bot removed the ci-failure PR has at least one CI failure label Feb 5, 2025
RobotSail
RobotSail suggested changes Feb 5, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@RobotSail RobotSail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @alimaredia, this looks pretty good! I just had a few areas where we need to make some changes, but aside from that it should be good to merge.

Comment thread docs/user/dk_bench.md Outdated
Comment thread docs/user/dk_bench.md
Comment thread docs/user/dk_bench.md Outdated
Comment thread docs/user/dk_bench.md Outdated
Comment thread docs/user/dk_bench.md Outdated
Comment thread docs/user/dk_bench.md Outdated
Comment thread docs/user/dk_bench.md Outdated
Comment thread docs/user/dk_bench.md Outdated
Comment thread docs/user/dk_bench.md Outdated
Comment thread docs/user/dk_bench.md Outdated
kelbrown20
kelbrown20 reviewed Feb 5, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@kelbrown20 kelbrown20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome so far! Just some clarification wording bits

Comment thread docs/user/dk_bench.md Outdated
Comment thread docs/user/dk_bench.md Outdated
Comment thread docs/user/dk_bench.md Outdated
Comment thread docs/user/dk_bench.md Outdated
Comment thread docs/user/dk_bench.md Outdated
Comment thread docs/user/dk_bench.md Outdated
Comment thread docs/user/dk_bench.md Outdated
reidliu41
reidliu41 reviewed Feb 6, 2025
View reviewed changes
Comment thread docs/user/dk_bench.md
@mergify mergify Bot added the ci-failure PR has at least one CI failure label Feb 6, 2025
RobotSail
RobotSail approved these changes Feb 6, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@RobotSail RobotSail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify Bot added the one-approval PR has one approval from a maintainer label Feb 6, 2025
andybraren
andybraren reviewed Mar 4, 2025
View reviewed changes
Copy link
Copy Markdown

@andybraren andybraren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nits I spotted while reading through the latest. Thanks for writing this up!

Comment thread docs/user/dk_bench.md Outdated
Comment thread docs/user/dk_bench.md Outdated
Comment thread docs/user/dk_bench.md Outdated
Comment thread docs/user/dk_bench.md Outdated
Comment thread docs/user/dk_bench.md Outdated
Comment thread docs/user/dk_bench.md Outdated
Comment thread docs/user/dk_bench.md Outdated
Comment thread docs/user/dk_bench.md Outdated
@mergify mergify Bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Mar 6, 2025
@mergify mergify Bot removed the ci-failure PR has at least one CI failure label Mar 6, 2025
@alimaredia
Copy link
Copy Markdown
Contributor Author

alimaredia commented Mar 6, 2025

@nathan-weinberg @reidliu41 @kelbrown20 could I get one more approval on this docs PR?

@mergify mergify Bot added the ci-failure PR has at least one CI failure label Mar 6, 2025
@mergify mergify Bot removed the one-approval PR has one approval from a maintainer label Mar 6, 2025
@alimaredia
docs: Add DK-Bench docs
1051d4b 
Signed-off-by: Ali Maredia <[email protected]>
@mergify mergify Bot added testing Relates to testing and removed ci-failure PR has at least one CI failure labels Mar 6, 2025
@nathan-weinberg
Copy link
Copy Markdown
Member

nathan-weinberg commented Mar 6, 2025

@alimaredia can you please go through and resolve threads where applicable? I cannot tell what has been responded to and what has not

@mergify mergify Bot merged commit 8955f30 into instructlab:main Mar 6, 2025
@nathan-weinberg
Copy link
Copy Markdown
Member

nathan-weinberg commented Mar 6, 2025

Never mind I guess...

@reidliu41
Copy link
Copy Markdown
Contributor

reidliu41 commented Mar 6, 2025

@nathan-weinberg I think should be resolve, I checked all the conversation before approved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@andybraren andybraren andybraren left review comments

@kelbrown20 kelbrown20 kelbrown20 left review comments

@reidliu41 reidliu41 reidliu41 approved these changes

@RobotSail RobotSail RobotSail approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CI/CD Affects CI/CD configuration documentation Improvements or additions to documentation testing Relates to testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@alimaredia @nathan-weinberg @reidliu41 @andybraren @kelbrown20 @RobotSail