Conversation
|
@radeksm please fix DCO signoff |
mergify
Bot
added
CI/CD
Missing DCO signoff added, thanks ! |
|
Squash and rebasing should fix the CI issues, sorry about that |
Any attempt to switch context ended up with:
File "/Users/xx/src/xxx/instructlab/src/instructlab/utils.py", line 797, in is_model_gguf
with model_path.open("rb") as f:
^^^^^^^^^^^^^^^
AttributeError: 'str' object has no attribute 'open'
Unfortunately changing the argument of get_model_arch() from string to
pathlib.Path does not fully resolve the problem because get_sysprompt()
and get_sysprompt had a different argument list, in order to unify both
I added arch string argument to get_cli_helper_sysprompt() which is
ignored but in that way both functions accept the same list of
arguments.
Fixes: instructlab#2730
Signed-off-by: Radoslaw Smigielski <[email protected]>
build(deps): bump docker/build-push-action from 6.9.0 to 6.10.0
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.9.0 to 6.10.0.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@4f58ea7...48aba3b)
---
updated-dependencies:
- dependency-name: docker/build-push-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <[email protected]>
Add disk check after tests run
Signed-off-by: Dan McPherson <[email protected]>
|
Hi @reidliu41, when it comes to your review https://github.com/instructlab/instructlab/pull/2731/commits, with all the respect I am not sure if we want to introduce new |
|
This pull request has been automatically marked as stale because it has not had activity within 60 days. It will be automatically closed if no further activity occurs within 30 days. |
|
This pull request has merge conflicts that must be resolved before it can be merged. @radeksm please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork |
|
This pull request has merge conflicts that must be resolved before it can be merged. @radeksm please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork |
|
This pull request has merge conflicts that must be resolved before it can be merged. @radeksm please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork |
|
believe it was fixed in #2731 |
4 participants
Any attempt to switch context ended up with:
File "/Users/xx/src/xxx/instructlab/src/instructlab/utils.py", line 797, in is_model_gguf
with model_path.open("rb") as f:
^^^^^^^^^^^^^^^
AttributeError: 'str' object has no attribute 'open'
Unfortunately changing the argument of get_model_arch() from string to pathlib.Path does not fully resolve the problem because get_sysprompt() and get_sysprompt had a different argument list, in order to unify both I added arch string argument to get_cli_helper_sysprompt() which is ignored but in that way both functions accept the same list of arguments.
Fixes: #2730