SDKJAVA-118: Upgrade Wiremock dependency#52
Merged
Conversation
timea-solid
approved these changes
Sep 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrades our use of Wiremock. The more recent versions (newer than 2 years ago) use a different
artifactId, which is why dependabot doesn't pick up the change. Note also the use ofHTTP/1.1in some of the tests. For now, as we are using plain HTTP connections in the test interactions, the HTTPS support isn't set up (which is where the HTTP/2 connections are relevant).That change would be a separate improvement, but this allows us to move the dependency forward.
Please also note that, when Wiremock starts to support Jersey 11 (it currently uses the EOL version 9), there will be a major version bump and the
artifactIdwill go back to justwiremock.