JCL-190: Use commons-rdf#187
Merged
Merged
Conversation
acoburn
force-pushed
the
JCL-190-commons-rdf
branch
from
December 22, 2022 21:19
17a51ea to
f3898c4
Compare
Contributor
|
I keep looking at the rd4j commons. Why not use org.apache.commons.rdf.rdf4j: https://commons.apache.org/proper/commons-rdf/implementations.html#Eclipse_RDF4J ? |
Contributor
Author
Because it only works with RDF4J 2.x. When using RDF4J 4.x, it completely blows up because the call to |
timea-solid
approved these changes
Dec 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces our custom RDF wrapping code with code from the Apache commons-rdf project. This results in considerably less code for us to maintain