Repository navigation
Conversation
Parked before the first edit. The plan and the workflow-to-check mapping are in the draft pull request description.
Contributor
Author
|
Superseded by #396, which pauses GitHub CI on PRs and main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress, parked. The branch holds one empty commit: no file has been changed yet. This description records the analysis done so far and the plan, so the work can resume from here.
Goal
Stop running GitHub CI on pull requests and run the same checks on our own machine instead:
pull_requesttriggers fromci.yml,quickstart.yml,docker.ymlandfull-suite.yml, keeping push and manual dispatch.scripts/ci-local.shandmake ci-local, which run those checks in parallel and post one commit status namedci-localon the tested commit.TESTING.mdandCONTRIBUTING.Done
main(read-only): it lists no required status checks, so removing the PR triggers will not block merges.docker,uv,node,npm,rustup,ghandjqare present.cargo-deny,cargo-audit,gitleaksandcargo-tarpaulinare missing, so the script has to install the pinned versions as the workflows did.Remaining
make ci-localon the PR head and add its summary and the posted status here.Planned mapping (not implemented yet)
Default run, what an ordinary PR used to get:
ci.ymlDetect changesorigin/main; an override forces every checkci.ymlFormatmake fmt-checkci.ymlSecret scan and hooksmake install-gitleaks,make secret-check,make hooks-testci.ymlClippymake lintci.ymlSupply chaincargo-denyandcargo-audit(same versions and checksums), fresh lockfiles, same commandsci.ymlTestsmake unit-test, then affected snapshot specs against the same debug build, then per-binary timingsci.ymlPython SDK (3.10, 3.12)make python-testonce per version, each in its own virtualenvci.ymlJS SDKmake pre-pr-jsquickstart.ymlREADME quick startsdocker buildof the engine image under a throwaway name, thenscripts/check-quickstarts.shOpt-in full run, what a PR labeled
releaseused to get:full-suite.ymlTests (full)make ci-test-allfull-suite.ymlDocumentationmake doc-checkfull-suite.ymlWebsitenpm ciandnpm run buildinfront/full-suite.ymlCoveragemake coverage,make view-coveragefull-suite.ymlPython langchain integrationmake python-test-live,make python-test-examplesfull-suite.ymlJS SDK query examplesmake js-test-livefull-suite.ymlPython SDK query examplesmake python-sdk-livefull-suite.ymlPerformance gate toolmake perf-gate-checkfull-suite.ymlVerified Completions gatemake vc-gatefull-suite.ymlMSRVcargo +1.88 check --all-featuresdocker.ymlBuild (amd64)docker buildof the engine and gateway targetsWill not run locally, and will be named as such in the summary:
full-suite.ymlPerformance gatemake perf-gate-remote)full-suite.ymlViews benchmarkperf_gate_onlydispatch only); benchmark hostdocker.ymlBuild (arm64)docker.ymlMerge manifestsOpen points for the resume
ci.ymlhas no trigger other thanpull_request, so removing it leaves an invalid workflow. Plan: make it manual-dispatch only and drop the PR-only path filter and label conditions.quickstart,python-test-liveandpython-test-examplesuse port 8080, and the latter two kill whatever holds it. Plan: the script refuses those checks when the port or theinputlayercontainer name is taken, instead of clobbering another lane.target/and run in sequence in one lane; the other checks run beside it.