Skip to content

fix(iql): accept range-restricted computed variables and lower concat comparisons correctly - #206

Merged
jsam merged 1 commit into
mainfrom
fm/il-iql1
Oct 3, 2026
Merged

jsam merged 1 commit into
mainfrom
fm/il-iql1

Conversation

@jsam

@jsam jsam commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Draft for visibility. Stacked on the release checkpoint 1 branch (fm/il-rc1); it will be retargeted to main once checkpoint 1 lands, and validated through the no-mistakes pipeline before merge.

Tracker: #199

…n comparisons

GenBI live validation hit two errors on valid IQL; three independent
causes sat behind them.

- Persistent-rule serialization mapped FunctionCall, BoolConstant,
  VectorLiteral, FieldAccess, RecordPattern and hnsw_nearest to `_`, so
  `C = concat(..)` failed the head-safety check and
  `concat(..) != concat(..)` lowered to `Placeholder NotEqual Placeholder`.
  It also made `user(Id, Name, true)` in a persistent rule match every
  row; 11_booleans.iql.out had recorded those wrong rows and is corrected.
  SerializableTerm/SerializableBodyPred now mirror every AST variant.
- Lowering had no filter shape for a function-call operand or arithmetic
  on both sides, and treated `Y = f(X)` with Y already bound as an
  assignment, silently dropping the filter. A new pass hoists such
  operands into `$cmpN` computed columns, and one classifier
  (assignment_target) now decides assignments for both the hoist and
  build_computed_columns, replacing the drifting pre-compute-schema check.
- BodyPredicate::variables ignored variables nested in comparison
  operands, so SIP copied `concat(A,..) != concat(B,..)` into reducer
  rules that cannot bind B. It now returns nested variables, which also
  retires the deep-variable workaround in validate_rule.

Compile path only; plans for previously supported rules are unchanged.
@jsam
jsam changed the base branch from fm/il-rc1 to main October 3, 2026 20:46
@jsam
jsam marked this pull request as ready for review October 3, 2026 20:46
@jsam jsam closed this Oct 3, 2026
@jsam jsam reopened this Oct 3, 2026
@jsam
jsam merged commit 277c7f0 into main Oct 3, 2026
23 of 26 checks passed
@jsam
jsam deleted the fm/il-iql1 branch October 3, 2026 20:55
jsam added a commit that referenced this pull request Oct 3, 2026
* fix(ir): make each '_' in a rule body a fresh anonymous variable

Lowering named a placeholder column after its relation and position
(_ph_{relation}_{i}), so two body atoms over one relation with '_' at the
same position joined on it. w(A,B) <- user(A,_,_), user(B,_,_) returned
only the diagonal and two(X,Z) <- e(X,Y,_), e(Y,Z,_) returned nothing,
for session and persistent rules alike. Name placeholders per atom
(_ph_a{atom}_c{i}), like constants already are.

The naming dates from 2024, so this is long-standing, not a #206
regression.

* test(snapshots): record correct results now that '_' never joins

25_running_total and 30_self_comparison had recorded the wrong rows
(counts of 1, no results) produced by joined placeholders. The debug
snapshots show the new per-atom placeholder column names.
jsam added a commit that referenced this pull request Oct 4, 2026
…ry request (#249)

The release-checkpoint performance gate fails on main: cheap_query serial
p50 is 1.110x the approved baseline e732cd5 on the 32-vCPU runner
(115 -> 126 us). Concurrent latency and throughput did not move. Bisected
to #214 (per-connection request pipelining), made worse by #222.

Cause: the pipeline runs requests in a `FuturesUnordered`. Its `poll_next`
wakes its own task and returns `Pending` after any poll that polled every
future in the set. With one request in flight, which is every serial
client, that happens on each request's first poll. The connection task
wakes itself, tokio schedules that as a yield, and a yield wakes an idle
worker to take the task. Each request therefore costs one more context
switch (4.0 -> 5.0 per query) and a hand-off of the connection task to
another core. #222 added no work per query but made the hand-off dearer:
user cycles per query rose 15% at the same instruction count.

Fix: keep one never-woken future in the set. After the pipeline's first
poll it is never polled again, so no poll reaches every future and the
forced yield no longer fires. The yield after futures that wake
themselves still applies. Pipelining, ordering, deadlines, cancellation
and the credential fence are unchanged. Nothing is added per request: no
lock, atomic or allocation. Each connection gets one more set node.

Bisect (cheap_query, `?edge(1, Y)`, serial). Server counters per query
from perf stat. Ratios are against e732cd5, from an interleaved probe
with one pinned server per commit, 40 rounds:

| commit | PR | user instr/query | ctx switches/query | p50 ratio |
|---|---|---|---|---|
| e732cd5 | baseline | 1.282M | 4.0 | 1.000 |
| d75ce6e | #208 atomic programs | 1.279M | 4.0 | 0.993 |
| 4578fe6 | #215 notification stream | 1.271M | 4.0 | 0.991 |
| 71a4d24 | #216 online backup | 1.275M | 4.0 | 1.016 |
| 2f621c5 | #200 first-update latency | 1.272M | 4.0 | 1.009 |
| e96df5c | #207 | 1.279M | 4.0 | 0.998 |
| 4dd8fe9 | #209 shard index | 1.272M | 4.0 | 0.987 |
| 277c7f0 | #206 | 1.274M | 4.0 | 1.008 |
| 3554c98 | #214 pipelining, deadlines | 1.296M | 5.0 | 1.020 |
| 3492a59 | #213 | 1.294M | 5.0 | 1.030 |
| 2ba9a5a | #212 provenance | 1.297M | 5.0 | 1.029 |
| 9ed61b4 | #204 key expiry | 1.297M | 5.0 | 1.027 |
| be35ee3 | #221 | 1.297M | 5.0 | 1.013 |
| c98a590 | #222 bounded streaming | 1.298M | 5.0 | 1.047 |
| a6fd628 | #219 wildcard fix | 1.297M | 5.0 | 1.061 |
| b7f7ad6 | #220 WAL durability | 1.300M | 5.0 | 1.056 |
| de54807 | #223 shared standing eval | 1.299M | 5.0 | 1.071 |
| 55ec34d | #225 checkpoint-1 fixes | 1.300M | 5.0 | 1.045 |
| 23712b8 | main | 1.300M | 5.0 | 1.064 |
| this change | | 1.300M | 4.0 | 1.033 |

Confirming A/Bs with the gate's own fixture (fresh pinned servers each
round, 40 rounds, ratio [95% interval]):

- #214 vs its parent 277c7f0: 1.039 [1.027..1.049]
- #222 vs its parent be35ee3: 1.025 [1.006..1.044]
- A/A 3554c98: 1.010 [1.002..1.025]
- e732cd5 -> main: 1.048 [1.028..1.066]
- main -> this change: 0.978 [0.958..0.989]
- e732cd5 -> this change: 1.021 [1.009..1.044], PASS (budget 1.05)

User cycles per query (perf stat, same instruction count): e732cd5 958K,
be35ee3 1053K, c98a590 1206K, this change 1006K.

Full gate, all fixtures, 20 rounds, servers pinned to CPUs 2-15:

- main -> this change: no metric worse. Every required metric is PASS, or
  INCONCLUSIVE with an interval that includes 1.0. cheap_query p50 0.979
  [0.953..1.007].
- e732cd5 -> this change: cheap_query p50 1.029 [1.019..1.072],
  INCONCLUSIVE on a busy host (load average up to 22); bound_query p50
  1.022, PASS. The insert and delta metrics improved since the baseline.

The shared host is about 4x slower per query than the CI runner, so the
same hand-off is a smaller share of each query here than there.

The remaining ~1.7% of user instructions per query since #214 is the
pipeline's own per-request bookkeeping: the boxed request future (one
4-8 KiB allocation), its set node, the request control and the in-flight
maps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant