Skip to content

Add pre-commit hooks for format and lint checks #44

Closed
Closed
Add pre-commit hooks for format and lint checks#44
Assignees
jsam
Labels
P3Maintenance, diagnostics or explicitly deferred workbackendBackend/server relatedenhancementNew feature or requestinfraInfrastructure, CI/CD, DevOpssdkPython, JavaScript and Rust clients and CLI
Milestone
Ops & resources

Description

@jsam
jsam
opened on Mar 17, 2026

Problem

.git/hooks/ has only sample files. Developers must manually remember to run make check. CI catches issues but late in the feedback loop.

Action

  • Add a .pre-commit-config.yaml with hooks for:
    • rustfmt (formatting)
    • clippy (linting)
    • eslint for GUI TypeScript
    • Secret detection (e.g. detect-secrets)
  • Document hook installation in CONTRIBUTING

Generated from production readiness audit

Activity

  1. jsam
    self-assigned this
    on Mar 17, 2026
  2. jsam
    added
    enhancementNew feature or request
    infraInfrastructure, CI/CD, DevOps
    on Mar 17, 2026

  3. jsam commented on Oct 1, 2026

    @jsam
    jsam
    on Oct 1, 2026
    ContributorAuthor

    CI already enforces fmt and clippy. Remaining: gitleaks in CI, an optional make install-hooks (fmt-check plus gitleaks), and CONTRIBUTING pointing at the exact CI commands. Mostly delivered by wp-ci-gate.

  4. jsam
    added this to the Ops & resources milestone on Oct 3, 2026
  5. jsam
    added
    backendBackend/server related
    sdkPython, JavaScript and Rust clients and CLI
    P3Maintenance, diagnostics or explicitly deferred work
    on Oct 3, 2026
  6. jsam
    added 2 commits that reference this issue on Oct 3, 2026

    build(hooks): optional fmt/secret hooks and a gitleaks CI scan

    520881d

    build(hooks): optional fmt/secret hooks and a gitleaks CI scan (#203)

    d9631b9

  7. jsam commented on Oct 3, 2026

    @jsam
    jsam
    on Oct 3, 2026
    ContributorAuthor

    Done in #203 (optional pre-commit/pre-push hooks, gitleaks secret scan, CI check), merged with CI green.

  8. jsam
    closed this as completedon Oct 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P3Maintenance, diagnostics or explicitly deferred workbackendBackend/server relatedenhancementNew feature or requestinfraInfrastructure, CI/CD, DevOpssdkPython, JavaScript and Rust clients and CLI

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions