You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
probe admission timeout counted as failed probe causes long backoff #252
Follow-up to #232 (shared parameterized standing-query views). Found in review and accepted as-is: sharing is only delayed, and results stay correct.
Problem
Sharing probes for parameterized view families queue on a dedicated server-wide probe semaphore of width 1 (PROBE_PERMITS) through supervise::admit. That admission gives up after MAX_ADMISSION_WAIT (30 s) with a "Server overloaded" error. Family::evaluate treats any run_query error as a failed probe and calls stop_sharing(), which increments stops. The family then waits probe_after(bindings, 1) = 256 × bindings commits before it tries again.
Scenario: many families become due at once, each with a slow lifted round (for example several ~330 ms recursive families plus many others). Families at the back of the FIFO queue time out without ever evaluating, and they back off as if their round had been judged too slow. Each queued probe also keeps its snapshot pinned for up to 30 s.
Fix
For a probe, an admission timeout (or any error before the round ran) is not a stop. It should only clear probing, so the next due point retries. Consider also not pinning the snapshot while a probe waits for its permit: take a fresh snapshot once admitted.
Evidence
The review finding text is in the PR's pipeline run 01M43D7SN7K9F0HATBNA3992QD (finding probe-queue-timeout-counts-as-failure, src/protocol/subscription/parameterized.rs). The session-scale before/after tables are in the PR description.
Activity
jsam commentedon Oct 4, 2026
Moved to the Engine production readiness milestone, the current focus (tracker #199). EN-11 (session scale): probe-admission follow-up of PR #254.
Roadmap per the neurosymbolic decision layer plan: engine production readiness first, then gateway neural integration with Jev, CLM and Laya (#266).
jsam commentedon Oct 5, 2026
Superseded by #318 (V11) in the incremental-views plan, epic #305.