Skip to content

fix(node-tests): adapt test infra to HostNotifier trait#108

Merged
prestwich merged 2 commits into
developfrom
fix/node-tests-host-notifier
Mar 20, 2026
Merged

fix(node-tests): adapt test infra to HostNotifier trait#108
prestwich merged 2 commits into
developfrom
fix/node-tests-host-notifier

Conversation

@prestwich

@prestwich prestwich commented Mar 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

[Claude Code]

Summary

Decouples signet-node-tests from reth's ExEx types by introducing a channel-backed test notifier.

  • TestHostNotifier: unbounded-channel HostNotifier implementation for integration tests — no reth ExEx dependency
  • to_host_notification(): converts signet_test_utils::ExExNotification → HostNotification<Chain> directly, replacing the ToRethPrimitive conversion chain
  • Removes blob_test_utils module (replaced by inline BlobFetcher::builder().with_test_pool())
  • Drops signet-host-reth, reth-exex, and reth-node-api deps from signet-node-tests
  • Updates SignetTestContext::new() and test_genesis to use TestHostNotifier + explicit builder API

PR stack

This is part of the host context adapter refactor. PRs #104 and #105 are already merged.

Merge in order:

  1. feat: add signet-host-reth crate with RethHostNotifier #106 ← signet-host-reth
  2. feat: add signet-host-rpc crate with RpcHostNotifier #107 ← signet-host-rpc (based on feat: add signet-host-reth crate with RethHostNotifier #106)
  3. fix(node-tests): adapt test infra to HostNotifier trait #108 ← test infra cleanup (this PR, based on feat: add signet-host-rpc crate with RpcHostNotifier #107)

Test plan

  • cargo clippy -p signet-node-tests --all-features --all-targets — clean
  • cargo clippy --workspace --all-features --all-targets — clean
  • cargo +nightly fmt --check — clean

🤖 Generated with Claude Code

@prestwich
prestwich requested a review from a team as a code owner March 14, 2026 12:18
@prestwich
prestwich marked this pull request as draft March 14, 2026 12:21
@prestwich

prestwich commented Mar 14, 2026

Copy link
Copy Markdown
Member Author

[Claude Code]

Note: This PR targets feat/host-rpc (PR #107), not develop. It should be merged into #107 before that PR lands.

This was referenced Mar 14, 2026
Merged
Merged
@prestwich
prestwich force-pushed the fix/node-tests-host-notifier branch from f74d3a3 to 6b17714 Compare March 17, 2026 16:03
@prestwich
prestwich force-pushed the fix/node-tests-host-notifier branch from 6b17714 to f74d3a3 Compare March 17, 2026 16:20
@prestwich
prestwich force-pushed the feat/host-rpc branch 2 times, most recently from 6b4707e to ab85fdf Compare March 17, 2026 16:41
@prestwich
prestwich force-pushed the fix/node-tests-host-notifier branch from f74d3a3 to 4386c99 Compare March 17, 2026 16:41
@prestwich
prestwich force-pushed the fix/node-tests-host-notifier branch from 4386c99 to 1344bf9 Compare March 17, 2026 17:03
@prestwich
prestwich force-pushed the fix/node-tests-host-notifier branch 2 times, most recently from 4b96a19 to 46673c4 Compare March 18, 2026 12:31
@prestwich
prestwich changed the base branch from feat/host-rpc to feat/host-notifier-trait March 18, 2026 12:31
@prestwich
prestwich force-pushed the fix/node-tests-host-notifier branch 2 times, most recently from 342b828 to 1b348d1 Compare March 18, 2026 13:50
@prestwich
prestwich marked this pull request as ready for review March 18, 2026 13:55
@prestwich
prestwich requested a review from Fraser999 March 18, 2026 13:55
@prestwich
prestwich changed the base branch from feat/host-notifier-trait to develop March 18, 2026 13:56
@prestwich prestwich closed this Mar 18, 2026
@prestwich prestwich reopened this Mar 18, 2026
@prestwich prestwich changed the title [hackathon] fix(node-tests): adapt test infra to HostNotifier trait fix(node-tests): adapt test infra to HostNotifier trait Mar 18, 2026
@prestwich
prestwich force-pushed the fix/node-tests-host-notifier branch 2 times, most recently from 408976d to 93520b1 Compare March 18, 2026 20:04
@prestwich
prestwich changed the base branch from develop to feat/host-rpc March 18, 2026 20:04
@prestwich prestwich mentioned this pull request Mar 18, 2026
Merged
6 tasks
@prestwich
prestwich marked this pull request as draft March 18, 2026 20:21
@prestwich
prestwich force-pushed the fix/node-tests-host-notifier branch from 93520b1 to 6a99b2e Compare March 19, 2026 12:26
Fraser999
Fraser999 approved these changes Mar 19, 2026
View reviewed changes

@Fraser999 Fraser999 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick only.

Comment thread crates/node-tests/src/context.rs Outdated
@prestwich
prestwich force-pushed the feat/host-rpc branch 2 times, most recently from ae53659 to a8bfea2 Compare March 19, 2026 14:57
@prestwich
prestwich force-pushed the fix/node-tests-host-notifier branch 2 times, most recently from 550fd17 to aee6ae1 Compare March 19, 2026 15:06
@prestwich prestwich mentioned this pull request Mar 20, 2026
Merged
10 tasks
@prestwich
prestwich force-pushed the fix/node-tests-host-notifier branch from b21848c to b2fd16d Compare March 20, 2026 18:22
@prestwich
prestwich changed the base branch from feat/host-rpc to develop March 20, 2026 18:22
@prestwich
prestwich marked this pull request as ready for review March 20, 2026 18:22
@prestwich
prestwich merged commit c2ebda7 into develop Mar 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fraser999 Fraser999 Fraser999 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@prestwich @Fraser999