Update README (add ref to tslink)#285
Merged
Merged
Conversation
Contributor
Author
|
Hello @sehz , would be nice to see your opinion about this PR and its subject |
Contributor
Author
|
you can try with example of combined usage |
|
@morenol WDYT? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, guys.
I have one suggestion for you and I'm doing it via PR ;)
Since I've been using node-bindgen for a long time already across a couple of projects I found missing TypeScript types a little annoying ).
That's just not comfortable from a testing and developing perspective.
You know, some small changes in data type on the native module side, and you shouldn't forget to update it on nodejs side too.
With TypeScript it is much easier. Imagine workflow:
You see? If some changes happen on step 1, on the heights level (nodejs) TypeScript compiler will inform about any errors. It makes a solution more stable and helps with testing indeed.
I've developed crate tslink which generates
*.d.ts,*.jsand*.tsfiles and actually creates a full-fledged npm package.As a bonus - code highlights on the IDE level as well.
What do you think about it?
If you are finding this useful for your users, let's add some remarks about it to your documentation.
P.S.
Combined usage
tslinkandnode-bindgenis very much covered by tests, you can see it in repo of the project.