Consider undefined/null for optional rust types (close #278)#280
Merged
Conversation
Contributor
Author
|
related to #278 |
Closed
Contributor
|
@DmitryAstafyev can you rebase on #281 is merged? Can we add a new test/example for this case? |
DmitryAstafyev
force-pushed
the
master
branch
from
7e83425 to
ea9423c
Compare
Contributor
Author
done |
Contributor
Author
|
@morenol tests are green ) |
Contributor
Author
Sorry, missed this question. I guess, yes... give me a try |
Contributor
Author
|
@morenol test has been added. Test has been passed ) we are green |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before parsing value from JS and converting it into rust-type, checking for
null/undefinedand consider it asOption<T>