Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing a text stream to the C backend’s
copy_stream()can crash the interpreter. Both compressor and decompressor ignore a failedPyBytes_AsStringAndSize()call and continue with invalid read-buffer state.Return through the existing cleanup path when conversion fails, preserving
TypeError. Tests useStringIO, invalid EOF/read values, and a type error after a valid chunk; they also reuse the same context for a successful stream afterward.Validation on Python 3.14: warnings-as-errors C build; C suite 254 passed / 44 skipped / six subtests passed; CFFI suite 228 passed / 70 skipped. Before the fix, four isolated cases crashed with SIGSEGV and one reported a wrong decompression error; all ten regression/control subprocesses pass afterward. Ruff lint and changed-file format checks pass. Whole-repository format check finds an unchanged setup.py indentation difference; slow/fuzz CI profile, Rust, other Python versions and non-Linux platforms were not run.
Fixes #375.