Issue #273: Caching Patterns [new pattern] - #277
Conversation
…lation errors + decrease in code coverage
Remarks:
|
|
@waisuan I'm done reviewing. Overall the implementation looks good. When you've implemented the changes please comment on this thread and I'll check again. |
|
Hello @iluwatar. Thanks for the feedback. Kindly check the latest changes and let me know if there is anything else that I have missed out. Thanks. P.S. And yes, I have left an option to use MongoDB as the backend DB as an alternative. Initially, I was testing with Mongo but it slipped my mind that this approach might cause the global maven compilation to fail when running the tests. So, I set the default DB to an internal structure instead to avoid said issue. Also, you're correct -- setting the flag in
|
Issue #273: Caching Patterns [new pattern]
|
Thank you very much for the valuable contribution! |
2 solutions
Hello.
Feel free to review the code that I have committed for the new/mentioned pattern. Do let me know if you discover any issues with the commit.
Thanks!