feat: add docker login on dockerhub registry to use iExec rate limits - #113
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds explicit Docker Hub authentication to the reusable Docker build workflow so pulls/builds use authenticated Docker Hub rate limits.
Changes:
- Document new Docker Hub-specific secrets (
dockerhub-username,dockerhub-password) and show them in the example usage. - Update the reusable workflow to accept Docker Hub secrets and perform a Docker Hub login before subsequent steps.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
docker-build/README.md |
Documents the new Docker Hub secrets and updates the usage example. |
.github/workflows/docker-build.yml |
Adds workflow_call secrets for Docker Hub and logs into Docker Hub via docker/login-action. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
thewhitewizard
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.