Skip to content

Migrate IexecCategoryManager to Typescript & Hardhat - #97

Merged
zguesmi merged 5 commits into
developfrom
feature/category-unit-tests-migration
Jul 30, 2024
Merged

Migrate IexecCategoryManager to Typescript & Hardhat#97
zguesmi merged 5 commits into
developfrom
feature/category-unit-tests-migration

Conversation

@zguesmi

@zguesmi zguesmi commented Jul 29, 2024

Copy link
Copy Markdown
Member

Minimal diff: Migrate file to Hardhat

@codecov

codecov Bot commented Jul 29, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.00%. Comparing base (e675764) to head (cbcebe9).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #97   +/-   ##
========================================
  Coverage    83.00%   83.00%           
========================================
  Files           34       34           
  Lines         1077     1077           
  Branches       222      222           
========================================
  Hits           894      894           
  Misses         183      183           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zguesmi
zguesmi marked this pull request as ready for review July 29, 2024 12:33
@zguesmi zguesmi self-assigned this Jul 29, 2024
Comment thread CHANGELOG.md Outdated

@james-toussaint james-toussaint left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thank you :)

Comment thread test/byContract/IexecCategoryManager/IexecCategoryManager.ts Outdated
Comment thread test/byContract/IexecCategoryManager/IexecCategoryManager.ts Outdated
Comment thread test/byContract/IexecCategoryManager/IexecCategoryManager.ts Outdated
Comment thread utils/poco-tools.ts
Comment thread test/byContract/IexecCategoryManager/IexecCategoryManager.ts Outdated
Comment thread test/byContract/IexecCategoryManager/IexecCategoryManager.ts Outdated
@zguesmi
zguesmi requested a review from james-toussaint July 30, 2024 09:40

@james-toussaint james-toussaint left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates 👍

@zguesmi
zguesmi merged commit e11a299 into develop Jul 30, 2024
@zguesmi
zguesmi deleted the feature/category-unit-tests-migration branch July 30, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants