Skip to content

Deploy and configure ENS with hardhat - #93

Merged
james-toussaint merged 2 commits into
developfrom
feature/deploy-ens-with-hardhat
Jul 5, 2024
Merged

Deploy and configure ENS with hardhat#93
james-toussaint merged 2 commits into
developfrom
feature/deploy-ens-with-hardhat

Conversation

@james-toussaint

Copy link
Copy Markdown
Contributor

No description provided.

@james-toussaint james-toussaint self-assigned this Jul 5, 2024
@james-toussaint
james-toussaint marked this pull request as ready for review July 5, 2024 09:47
@codecov

codecov Bot commented Jul 5, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.52%. Comparing base (247db2a) to head (33ec55d).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #93   +/-   ##
========================================
  Coverage    81.52%   81.52%           
========================================
  Files           34       34           
  Lines         1077     1077           
  Branches       222      202   -20     
========================================
  Hits           878      878           
  Misses         199      199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread deploy/1_deploy-ens.ts
Comment thread deploy/1_deploy-ens.ts Outdated
@james-toussaint
james-toussaint requested a review from zguesmi July 5, 2024 13:54

@zguesmi zguesmi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gfournierPro gfournierPro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks

@james-toussaint
james-toussaint merged commit 8dc9ea3 into develop Jul 5, 2024
@james-toussaint
james-toussaint deleted the feature/deploy-ens-with-hardhat branch July 5, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants