Skip to content

Sponsor match orders - #57

Merged
james-toussaint merged 10 commits into
developfrom
feature/sponsor-match-orders
Mar 19, 2024
Merged

Sponsor match orders#57
james-toussaint merged 10 commits into
developfrom
feature/sponsor-match-orders

Conversation

@james-toussaint

@james-toussaint james-toussaint commented Mar 18, 2024

Copy link
Copy Markdown
Contributor

In scope

  • New unit tests covering sponsor match orders ✔️

Out scope

  • New integration test featuring a match orders sponsoring ⏭️

@james-toussaint
james-toussaint marked this pull request as ready for review March 18, 2024 15:28
// SPDX-FileCopyrightText: 2020-2024 IEXEC BLOCKCHAIN TECH <[email protected]>
// SPDX-License-Identifier: Apache-2.0

// TODO: Remove header bellow

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be removed in some other next PRs if fine for you

const lowercaseAddress = ethers.utils.hexZeroPad(
BigNumber.from(events[0].args['tokenId']).toHexString(),
20,
);

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for:
Error: invalid address (argument="address", value="0x7a96932ea86a8a23f336f4800f404e6361d42b", code=INVALID_ARGUMENT, version=address/5.7.0) occurring some times.

@james-toussaint james-toussaint changed the title Feature/sponsor match orders Sponsor match orders Mar 18, 2024
Comment thread contracts/modules/delegates/IexecPoco1Delegate.sol Outdated
Comment thread contracts/modules/delegates/IexecPoco1Delegate.sol Outdated
}

/**
* Sponsor match orders for a requester.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Amxx FYI

@gfournierPro gfournierPro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Jérémy !

@james-toussaint
james-toussaint merged commit b6284dd into develop Mar 19, 2024
@james-toussaint
james-toussaint deleted the feature/sponsor-match-orders branch March 19, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants