Skip to content

Remove enterprise mode - #56

Merged
james-toussaint merged 4 commits into
developfrom
feature/remove-enterprise
Mar 19, 2024
Merged

Remove enterprise mode#56
james-toussaint merged 4 commits into
developfrom
feature/remove-enterprise

Conversation

@james-toussaint

Copy link
Copy Markdown
Contributor

No description provided.

@james-toussaint
james-toussaint marked this pull request as ready for review March 18, 2024 14:05

contract IexecERC20DelegateKYC is IexecERC20Delegate, IexecERC20CoreKYC
{
function _beforeTokenTransfer(address from, address to, uint256 amount)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also be removed from the ERC20Core contract

function _beforeTokenTransfer(address from, address to, uint256 amount)

@zguesmi

zguesmi commented Mar 18, 2024

Copy link
Copy Markdown
Member

Could you update the diagrams, please 🙏

@james-toussaint
james-toussaint requested a review from zguesmi March 19, 2024 09:15
Comment thread package.json
"devDependenciesComment": {
"mocha": "Mocha Test Explorer in VSCode"
"mocha": "Mocha Test Explorer in VSCode",
"sol2uml": "After 2.5.19, see https://github.com/naddison36/sol2uml/issues/183"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside the scope of this PR but Be aware of this!

@zguesmi zguesmi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the cleaning!

@gfournierPro gfournierPro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleaning, sorry for the metrics !

@james-toussaint
james-toussaint merged commit 6c31574 into develop Mar 19, 2024
@james-toussaint
james-toussaint deleted the feature/remove-enterprise branch March 19, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants