feat: upgrade hardhat - #313
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Hardhat development environment to newer versions and refines the storage layout compatibility checks to support RLC faucet contract dependencies.
- Updated Hardhat from 2.22.18 to 2.26.5 and added hardhat-verify plugin
- Upgraded Solidity compiler version for RLC contracts from 0.4.11 to 0.4.24
- Excluded rlc-faucet-contract from storage layout compatibility checks
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/check-storage.ts | Added filter to skip rlc-faucet-contract files from storage compatibility validation |
| package.json | Updated hardhat to 2.26.5 and added @nomicfoundation/hardhat-verify dependency |
| package-lock.json | Updated dependency tree for hardhat 2.26.5 and new dependencies |
| hardhat.config.ts | Updated RLC contracts compiler version from 0.4.11 to 0.4.24 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (!output.sources[src].ast) continue; | ||
|
|
||
| // Skip contracts from rlc-faucet-contract | ||
| if (src.includes('rlc-faucet-contract/')) { |
There was a problem hiding this comment.
The substring check using includes() may inadvertently skip files with 'rlc-faucet-contract/' anywhere in the path. Consider using a more precise check such as src.startsWith('node_modules/rlc-faucet-contract/') or checking against a normalized path to ensure only the intended dependency files are excluded.
| if (src.includes('rlc-faucet-contract/')) { | |
| if (src.startsWith('node_modules/rlc-faucet-contract/')) { |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { version: '0.8.21', settings: v8Settings }, // PoCo Boost | ||
| { version: '0.6.12', settings }, // PoCo contracts | ||
| { version: '0.4.11', settings }, // RLC contracts | ||
| { version: '0.4.24', settings }, // RLC contracts |
There was a problem hiding this comment.
[nitpick] The comment states 'RLC contracts' but the code change shows this is specifically for rlc-faucet-contract (based on the skip logic added in check-storage.ts). Consider updating the comment to be more specific, e.g., '// RLC faucet contract' to clarify which contracts use this compiler version.
| { version: '0.4.24', settings }, // RLC contracts | |
| { version: '0.4.24', settings }, // RLC faucet contract |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #313 +/- ##
=======================================
Coverage 96.53% 96.53%
=======================================
Files 32 32
Lines 1069 1069
Branches 213 213
=======================================
Hits 1032 1032
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Replace PR #304