Add Diamond contract unit tests - #224
Merged
zguesmi merged 8 commits intoJul 25, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds unit tests for the Diamond contract as part of the migration to the Diamond pattern (ERC-2535). The tests verify Diamond contract deployment behavior, ownership setting, and facet cut functionality.
- Adds comprehensive unit tests for Diamond contract deployment scenarios
- Updates license headers to use SPDX-FileCopyrightText format
- Removes legacy Migrations.sol contract that's no longer needed
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/byContract/Diamond.test.ts | New test file covering Diamond deployment, ownership, and facet cut functionality |
| contracts/tools/Migrations.sol | Removed legacy migrations contract |
| contracts/Diamond.sol | Updated license header and comment formatting |
| CHANGELOG.md | Added entry documenting the new Diamond unit tests |
Comments suppressed due to low confidence (2)
test/byContract/Diamond.test.ts:66
- The fallback redirection functionality mentioned in the PR description is not tested. Consider implementing this test to ensure the Diamond proxy correctly redirects fallback calls to facets.
it.skip('[TODO] Should redirect fallback', async () => {});
test/byContract/Diamond.test.ts:67
- The receive redirection functionality mentioned in the PR description is not tested. Consider implementing this test to ensure the Diamond proxy correctly redirects receive calls to facets.
it.skip('[TODO] Should redirect receive', async () => {});
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/diamond #224 +/- ##
===================================================
+ Coverage 84.35% 84.44% +0.08%
===================================================
Files 37 37
Lines 1112 1112
Branches 225 225
===================================================
+ Hits 938 939 +1
+ Misses 174 173 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gfournierPro
approved these changes
Jul 25, 2025
| * @param deployer Signer to deploy the library. | ||
| * @returns The library configuration or an empty object. | ||
| */ | ||
| export async function getLibDiamondConfigOrEmpty(deployer: SignerWithAddress): Promise<any> { |
Contributor
There was a problem hiding this comment.
is it possible to type the promise output ?
Member
Author
There was a problem hiding this comment.
It generates a typing error so I use the generic type any.
Le-Caignec
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration steps:
receiveandfallbackbehavior inDiamond.solModuletoFacetin contracts namesDiamond.sol