Skip to content

Feature deploy on testnets with CreateX - #216

Merged
gfournierPro merged 27 commits into
developfrom
feature/deploy-on-testnets
Apr 24, 2025
Merged

Feature deploy on testnets with CreateX #216
gfournierPro merged 27 commits into
developfrom
feature/deploy-on-testnets

Conversation

@gfournierPro

Copy link
Copy Markdown
Contributor

No description provided.

@gfournierPro gfournierPro self-assigned this Apr 22, 2025
@codecov

codecov Bot commented Apr 22, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.50%. Comparing base (a8ffae3) to head (30e2086).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #216   +/-   ##
========================================
  Coverage    84.50%   84.50%           
========================================
  Files           35       35           
  Lines         1084     1084           
  Branches       221      221           
========================================
  Hits           916      916           
  Misses         168      168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread CHANGELOG.md Outdated
Comment thread config/config.json Outdated
Comment thread config/config.json
Comment thread package.json Outdated
Comment thread test/utils/hardhat-fixture-deployer.ts Outdated
Comment thread test/utils/hardhat-fixture-deployer.ts Outdated
Comment thread test/utils/hardhat-fixture-deployer.ts Outdated
Comment thread scripts/tools/copy-deployments.js Outdated
Comment on lines +9 to +10
const fs = require('fs-extra');
const path = require('path');

@Le-Caignec Le-Caignec Apr 22, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use import here ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread test/utils/fixture-helpers.ts Outdated
Comment thread test/utils/fixture-helpers.ts
Comment thread test/utils/fixture-helpers.ts
Comment thread test/utils/fixture-helpers.ts Outdated
Comment thread hardhat.config.ts Outdated
@@ -1,4 +1,5 @@
import '@nomicfoundation/hardhat-toolbox';
import * as dotenv from 'dotenv';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import * as dotenv from 'dotenv';
import 'dotenv/config'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread hardhat.config.ts Outdated
@@ -10,6 +11,7 @@ import {
} from 'hardhat/internal/core/config/default-config';
import 'solidity-docgen';
import chainConfig from './utils/config';
dotenv.config();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dotenv.config();

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zguesmi zguesmi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here, thanks!

Comment thread test/utils/fixture-helpers.ts
Comment thread test/utils/fixture-helpers.ts
@gfournierPro
gfournierPro merged commit aa27cae into develop Apr 24, 2025
@gfournierPro
gfournierPro deleted the feature/deploy-on-testnets branch April 24, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants