feature/migrate-IexecPoco-to-ethers6 - #196
Merged
Le-Caignec merged 36 commits intoFeb 19, 2025
Merged
Conversation
Le-Caignec
changed the title
Le-Caignec
marked this pull request as ready for review
February 17, 2025 12:09
zguesmi
reviewed
Feb 18, 2025
Co-authored-by: Zied Guesmi <[email protected]>
Co-authored-by: Jérémy (James) Toussaint <[email protected]>
| iexecPoco, | ||
| [requester, sponsor, appProvider, datasetProvider], | ||
| [ | ||
| 0, // requester balance is unchanged, only frozen is changed |
Contributor
There was a problem hiding this comment.
I think we can harmonize, 0 or 0n everywhere
Contributor
Author
There was a problem hiding this comment.
Some Number castings are still present in the code. Removing them in another PR might reveal the need to add explicit castings for some cases. I have only changed the ones that are actually consumed and where BigInt is required. I have minimized the changes as much as possible.
…est.ts Co-authored-by: Jérémy (James) Toussaint <[email protected]>
…est.ts Co-authored-by: Jérémy (James) Toussaint <[email protected]>
Co-authored-by: Jérémy (James) Toussaint <[email protected]>
…nto feature/migrate-IexecPoco-to-ethers6
james-toussaint
approved these changes
Feb 19, 2025
james-toussaint
left a comment
james-toussaint
left a comment
Contributor
There was a problem hiding this comment.
Good job thanks 💪 !
Comment on lines
+942
to
+943
| // const appOrderConsumedSlotIndex = ethers.keccak256( | ||
| // ethers.concat([ |
Contributor
There was a problem hiding this comment.
That's funny to update even the comments
Co-authored-by: gfournieriExec <[email protected]>
| @@ -200,15 +197,13 @@ describe('IexecPoco2#reveal', () => { | |||
| volume, | |||
| trust: 3, | |||
Contributor
There was a problem hiding this comment.
we don't want to migrate the trust as well in bigint ?
Contributor
Author
There was a problem hiding this comment.
yes it think but I have only changed lines/variables that are actually consumed and where BigInt is required. I have minimized the changes as much as possible.
gfournierPro
left a comment
gfournierPro
left a comment
Contributor
There was a problem hiding this comment.
Some minor comment but thanks huge work well done
gfournierPro
approved these changes
Feb 19, 2025
gfournierPro
approved these changes
Feb 19, 2025
zguesmi
approved these changes
Feb 19, 2025
…tools" This reverts commit cd14b8d.
…ss in IexecPoco2 finalize tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.