Skip to content

Feature/migrate registries tests ethers6 - #194

Merged
Le-Caignec merged 17 commits into
feature/migration-to-ether-v6from
feature/migrate-registries-tests-ethers6
Feb 20, 2025
Merged

Feature/migrate registries tests ethers6#194
Le-Caignec merged 17 commits into
feature/migration-to-ether-v6from
feature/migrate-registries-tests-ethers6

Conversation

@Le-Caignec

Copy link
Copy Markdown
Contributor

No description provided.

@Le-Caignec Le-Caignec self-assigned this Feb 17, 2025
Comment thread test/byContract/registries/registries.test.ts Outdated
Comment thread utils/tools.ts Outdated
Comment thread test/byContract/registries/registries.test.ts Outdated
Comment thread test/byContract/registries/assets.test.ts Outdated
Comment thread test/byContract/registries/assets.test.ts
Comment thread test/byContract/registries/assets.test.ts
Comment thread test/byContract/registries/registries.test.ts Outdated
Comment thread test/byContract/registries/registries.test.ts Outdated
@Le-Caignec
Le-Caignec marked this pull request as ready for review February 19, 2025 15:39

@james-toussaint james-toussaint left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

let contributeBlockTimestamp;
const viewFrozenOf = (address: string) =>
iexecPoco.frozenOf(address);
const viewFrozenOf = (address: string) => iexecPoco.frozenOf(address);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this diff now ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered the same thing. Maybe the formatting failed in another PR.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a suggestion applied from GitHub UI so no formatting for now

@gfournierPro gfournierPro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Comment thread test/byContract/registries/registries.test.ts Outdated
Comment thread test/byContract/registries/registries.test.ts Outdated
Comment thread test/byContract/registries/registries.test.ts Outdated
Comment thread test/byContract/registries/registries.test.ts Outdated
Comment thread test/byContract/registries/registries.test.ts Outdated
Comment thread test/byContract/registries/registries.test.ts Outdated
@Le-Caignec
Le-Caignec merged commit a681052 into feature/migration-to-ether-v6 Feb 20, 2025
@Le-Caignec
Le-Caignec deleted the feature/migrate-registries-tests-ethers6 branch February 20, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants