Remove unnecessary network reset - #186
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #186 +/- ##
========================================
Coverage 84.50% 84.50%
========================================
Files 35 35
Lines 1084 1084
Branches 221 221
========================================
Hits 916 916
Misses 168 168 ☔ View full report in Codecov by Sentry. |
Le-Caignec
left a comment
Le-Caignec
left a comment
There was a problem hiding this comment.
This PR makes me think that it could be a good idea to introduce Zod for environment validation, just like we did for the voucher repo.
james-toussaint
left a comment
james-toussaint
left a comment
There was a problem hiding this comment.
Great, thank you!
| * @param contractName contract name to deploy | ||
| * @param deployedAddress address where contract where deployed | ||
| */ | ||
| function saveDeployedAddress(contractName: string, deployedAddress: string) { |
There was a problem hiding this comment.
Are we all good in poco-chain?
There was a problem hiding this comment.
Yes, I have already checked that we break nothing in:
But I should note that some cleaning has to be done in poco-chain project, I created an issue with the required details: https://github.com/iExecBlockchainComputing/poco-chain/issues/25
It's a good idea, however, I'd rather keep it for a separate PR. |
4 participants
No description provided.