Skip to content

Remove migrated file 000_fullchain-ABILegacy.js - #175

Merged
zguesmi merged 2 commits into
developfrom
feature/abi-legacy-tests-cleaning
Jan 6, 2025
Merged

Remove migrated file 000_fullchain-ABILegacy.js#175
zguesmi merged 2 commits into
developfrom
feature/abi-legacy-tests-cleaning

Conversation

@zguesmi

@zguesmi zguesmi commented Jan 3, 2025

Copy link
Copy Markdown
Member

No description provided.

@zguesmi zguesmi self-assigned this Jan 3, 2025
@codecov

codecov Bot commented Jan 3, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.87%. Comparing base (3d91f5f) to head (5354068).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #175   +/-   ##
========================================
  Coverage    84.87%   84.87%           
========================================
  Files           35       35           
  Lines         1084     1084           
  Branches       221      221           
========================================
  Hits           920      920           
  Misses         164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gfournierPro gfournierPro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Le-Caignec
Le-Caignec self-requested a review January 6, 2025 09:38

@Le-Caignec Le-Caignec left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zguesmi
zguesmi marked this pull request as ready for review January 6, 2025 10:18
Base automatically changed from feature/abi-legacy-tests-migration to develop January 6, 2025 11:10
@zguesmi
zguesmi merged commit 7a1399e into develop Jan 6, 2025
@zguesmi
zguesmi deleted the feature/abi-legacy-tests-cleaning branch January 6, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants