Skip to content

Migrate 000_fullchain-ABILegacy.js file to Hardhat/TS - #174

Merged
zguesmi merged 8 commits into
developfrom
feature/abi-legacy-tests-migration
Jan 6, 2025
Merged

Migrate 000_fullchain-ABILegacy.js file to Hardhat/TS#174
zguesmi merged 8 commits into
developfrom
feature/abi-legacy-tests-migration

Conversation

@zguesmi

@zguesmi zguesmi commented Jan 3, 2025

Copy link
Copy Markdown
Member

No description provided.

it('[ABILegacy] Should return account', async function () {
const balanceAmount = 3;
await iexecWrapper.depositInIexecAccount(requester, balanceAmount);
const account = await iexecPocoABILegacy.viewAccountABILegacy(requester.address);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

@Le-Caignec Le-Caignec left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RAS on my side
Good job 👌🏼

Comment thread test/byContract/IexecAccessors/IexecAccessorsABILegacy.test.ts
@zguesmi
zguesmi marked this pull request as ready for review January 6, 2025 10:18
@codecov

codecov Bot commented Jan 6, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.87%. Comparing base (ae5ead6) to head (7d63e4d).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #174      +/-   ##
===========================================
+ Coverage    84.68%   84.87%   +0.18%     
===========================================
  Files           35       35              
  Lines         1084     1084              
  Branches       221      221              
===========================================
+ Hits           918      920       +2     
+ Misses         166      164       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zguesmi
zguesmi merged commit 5ef0221 into develop Jan 6, 2025
@zguesmi
zguesmi deleted the feature/abi-legacy-tests-migration branch January 6, 2025 11:10

@james-toussaint james-toussaint left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants