Remove unnecessary back and forth transfers in IexecPoco2Delegate - #167
Conversation
| .to.emit(iexecPoco, 'Transfer') | ||
| .withArgs(iexecPoco.address, kittyAddress, schedulerTaskStake) |
There was a problem hiding this comment.
Do we have the same here ?
There was a problem hiding this comment.
Thank you very much, I screened it first then moved on since test were OK.
I found a framework issue which forces us to check token balance changes before checking events, otherwise event checking never works ..!
We need to update that in both projects in next PRs (FYI @iExecBlockchainComputing/team-blockchain)
There was a problem hiding this comment.
Thanks for the point, we should keep in mind this !
Le-Caignec
left a comment
Le-Caignec
left a comment
There was a problem hiding this comment.
Everything looks good to me. Another approach could have been to add a new function in the IExecEscrow contract named rewardAndLock().
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #167 +/- ##
===========================================
+ Coverage 84.67% 84.68% +0.01%
===========================================
Files 35 35
Lines 1083 1084 +1
Branches 221 221
===========================================
+ Hits 917 918 +1
Misses 166 166 ☔ View full report in Codecov by Sentry. |
3 participants
No description provided.