Skip to content

clean todo on 000 it - #163

Merged
gfournierPro merged 18 commits into
developfrom
feature/clean-new-IT-test
Nov 26, 2024
Merged

clean todo on 000 it #163
gfournierPro merged 18 commits into
developfrom
feature/clean-new-IT-test

Conversation

@gfournierPro

Copy link
Copy Markdown
Contributor

No description provided.

@gfournierPro
gfournierPro requested a review from a team November 25, 2024 14:50
@gfournierPro gfournierPro self-assigned this Nov 25, 2024
@codecov

codecov Bot commented Nov 25, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.67%. Comparing base (e17654d) to head (5337b78).
Report is 19 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #163   +/-   ##
========================================
  Coverage    84.67%   84.67%           
========================================
  Files           35       35           
  Lines         1083     1083           
  Branches       221      221           
========================================
  Hits           917      917           
  Misses         166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@james-toussaint james-toussaint left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

Comment thread test/000_fullchain.test.ts Outdated
Comment thread test/000_fullchain.test.ts
Comment thread test/000_fullchain.test.ts Outdated
Comment thread test/000_fullchain.test.ts Outdated
Comment thread test/000_fullchain.test.ts Outdated
Comment thread test/000_fullchain.test.ts Outdated
Comment thread test/000_fullchain.test.ts Outdated
Comment thread test/000_fullchain.test.ts Outdated
Comment on lines +228 to +230
const workerStakePerTask = await iexecPoco
.viewDeal(dealId)
.then((deal) => deal.workerStake.toNumber());

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here.

Comment thread test/000_fullchain.test.ts Outdated
Comment thread test/utils/IexecWrapper.ts Outdated
* @param resultDigest hash of the result
* @returns id of the task
*/
async contributeTeeToTask(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
async contributeTeeToTask(
async contributeToTeeTask(

@gfournierPro
gfournierPro merged commit 45da3e4 into develop Nov 26, 2024
@gfournierPro
gfournierPro deleted the feature/clean-new-IT-test branch November 26, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants