migrate erc1154 ut part 2 - #147
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #147 +/- ##
========================================
Coverage 84.58% 84.58%
========================================
Files 35 35
Lines 1077 1077
Branches 201 221 +20
========================================
Hits 911 911
Misses 166 166 ☔ View full report in Codecov by Sentry. |
| const task = await iexecPocoAsAnyone.viewTask(taskId); | ||
| await expect(task.status).to.equal(TaskStatusEnum.COMPLETED); | ||
| await expect(await iexecPocoAsAnyone.callStatic.resultFor(taskId)).to.equal('0x'); | ||
| }); |
Contributor
There was a problem hiding this comment.
I think the test with result callback is missing
Contributor
There was a problem hiding this comment.
Add callback in buildOrders(..)?
| const task = await iexecPocoAsAnyone.viewTask(taskId); | ||
| await expect(task.status).to.equal(TaskStatusEnum.COMPLETED); | ||
| await expect(await iexecPocoAsAnyone.callStatic.resultFor(taskId)).to.equal('0x'); | ||
| }); |
Contributor
There was a problem hiding this comment.
Add callback in buildOrders(..)?
Co-authored-by: Jérémy James Toussaint <[email protected]>
zguesmi
reviewed
Oct 24, 2024
zguesmi
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate result
test/ERC1154/resultFor.js.skip