Skip to content

migrate verify ut - #136

Merged
james-toussaint merged 17 commits into
developfrom
feature/migrate-verify-UT
Sep 27, 2024
Merged

migrate verify ut#136
james-toussaint merged 17 commits into
developfrom
feature/migrate-verify-UT

Conversation

@gfournierPro

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Sep 26, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.02%. Comparing base (98cd6bc) to head (571aadf).
Report is 18 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #136   +/-   ##
========================================
  Coverage    84.02%   84.02%           
========================================
  Files           35       35           
  Lines         1077     1077           
  Branches       221      221           
========================================
  Hits           905      905           
  Misses         172      172           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread CHANGELOG.md Outdated
Comment thread test/byContract/IexecPoco/IexecPoco1.test.ts Outdated
Comment thread test/byContract/IexecPoco/IexecPoco1.test.ts Outdated
Comment thread test/byContract/IexecPoco/IexecPoco1.test.ts Outdated
Comment thread test/byContract/IexecPoco/IexecPoco1.test.ts Outdated
Comment thread test/byContract/IexecPoco/IexecPoco1.test.ts Outdated
Comment thread test/byContract/IexecPoco/IexecPoco1.test.ts Outdated
Comment thread test/byContract/IexecPoco/IexecPoco1.test.ts Outdated
Comment thread test/byContract/IexecPoco/IexecPoco1.test.ts Outdated
let orderHash: string;
let orderManagement: {
[key: string]: {
iexecPocoManageOrderTx: () => Promise<ContractTransaction>;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename both iexecPocoManageOrderTx l84 & 94 & etc to iexecPocoSignManageOrder

Comment thread test/byContract/IexecPoco/IexecPoco1.test.ts Outdated

@james-toussaint james-toussaint left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@james-toussaint
james-toussaint merged commit 31a1b17 into develop Sep 27, 2024
@james-toussaint
james-toussaint deleted the feature/migrate-verify-UT branch September 27, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants