Skip to content

Migrate ENSIntegration unit tests to Hardhat & Typescript - #105

Merged
zguesmi merged 7 commits into
developfrom
feature/ens-integration-tests-migration
Aug 9, 2024
Merged

Migrate ENSIntegration unit tests to Hardhat & Typescript#105
zguesmi merged 7 commits into
developfrom
feature/ens-integration-tests-migration

Conversation

@zguesmi

@zguesmi zguesmi commented Aug 9, 2024

Copy link
Copy Markdown
Member

No description provided.

@zguesmi zguesmi self-assigned this Aug 9, 2024
@zguesmi
zguesmi marked this pull request as ready for review August 9, 2024 10:23
@codecov

codecov Bot commented Aug 9, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.75%. Comparing base (2d52d65) to head (2cd47b3).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #105   +/-   ##
========================================
  Coverage    83.75%   83.75%           
========================================
  Files           34       34           
  Lines         1077     1077           
  Branches       202      222   +20     
========================================
  Hits           902      902           
  Misses         175      175           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread test/byContract/ENSIntegration/ENSIntegration.ts Outdated
Comment thread test/byContract/ENSIntegration/ENSIntegration.ts Outdated
Comment thread test/byContract/ENSIntegration/ENSIntegration.ts Outdated
Comment thread test/byContract/ENSIntegration/ENSIntegration.ts Outdated
Comment thread test/byContract/ENSIntegration/ENSIntegration.ts
@zguesmi
zguesmi requested a review from gfournierPro August 9, 2024 13:38
Comment thread test/byContract/ENSIntegration/ENSIntegration.test.ts
Comment thread test/byContract/ENSIntegration/ENSIntegration.test.ts
Comment thread test/byContract/ENSIntegration/ENSIntegration.test.ts

@gfournierPro gfournierPro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zguesmi
zguesmi merged commit 43e58a3 into develop Aug 9, 2024
@zguesmi
zguesmi deleted the feature/ens-integration-tests-migration branch August 9, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants