chore: Update deal tag comments - #280
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes the way deal tags are used across the codebase by replacing hardcoded string literals with named constants and using ethers' ZeroAddress constant instead of a custom null address constant.
- Introduces
TAG_STANDARDandTAG_TEEconstants for deal tags - Replaces
constants.NULL.ADDRESSwith ethers'ZeroAddress - Updates all test files to use the new constants consistently
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| utils/createOrders.ts | Imports ZeroAddress and replaces constants.NULL.ADDRESS usage |
| utils/constants.ts | Adds TAG_STANDARD and TAG_TEE constants, removes NULL.ADDRESS and unused objects |
| test/byContract/IexecPocoBoost/IexecPocoBoost.test.ts | Replaces hardcoded tag strings with TAG_TEE constant and uses ZeroAddress |
| test/byContract/IexecPoco/IexecPoco2-reveal.test.ts | Replaces hardcoded tag with TAG_STANDARD constant |
| test/byContract/IexecPoco/IexecPoco2-contribute.test.ts | Replaces hardcoded tags with TAG_STANDARD and TAG_TEE constants |
| test/byContract/IexecPoco/IexecPoco2-contribute-and-finalize.test.ts | Uses new tag constants and removes unused import |
| test/byContract/IexecPoco/IexecPoco1.test.ts | Replaces hardcoded tags with constants and fixes tag format |
| test/byContract/IexecAccessors/IexecAccessorsABILegacy.test.ts | Uses TAG_STANDARD constant |
| test/300_fullchain-reopen.test.ts | Uses TAG_STANDARD constant |
| test/201_fullchain-multi-orders.test.ts | Uses TAG_STANDARD constant |
| test/200_fullchain-bot.test.ts | Uses TAG_STANDARD constant |
| test/000_fullchain.test.ts | Uses TAG_STANDARD and TAG_TEE constants |
| test/000_fullchain-boost.test.ts | Uses TAG_TEE constant |
| contracts/facets/IexecPoco1Facet.sol | Improves tag compatibility comments and code organization |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
==========================================
+ Coverage 83.66% 84.82% +1.16%
==========================================
Files 38 37 -1
Lines 1218 1239 +21
Branches 227 235 +8
==========================================
+ Hits 1019 1051 +32
+ Misses 199 188 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gfournierPro
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.