Consolidates data dir under pinot home - #24
Merged
Merged
Conversation
This makes working with layers immensely easier. This is not complete as I noticed pinot is still looking at var likely due to some variable we aren't setting.
codefromthecrypt
changed the title
codefromthecrypt
marked this pull request as ready for review
September 3, 2020 08:58
codefromthecrypt
requested review from
aaron-steinfeld,
buchi-busireddy,
laxmanchekka,
ravisingal and
tim-mwangi
as code owners
September 3, 2020 08:58
jcchavezs
reviewed
Sep 3, 2020
codefromthecrypt
commented
Sep 3, 2020
| @@ -1,10 +1,8 @@ | |||
| # Choose libraries we need from Pinot's image. | |||
| FROM apachepinot/pinot:0.5.0-SNAPSHOT-a892fb40b-20200829 as install | |||
| FROM apachepinot/pinot:0.5.0-rc1 as install | |||
Author
There was a problem hiding this comment.
latest is rc2 but that's not in docker yet. doesn't matter though except we are closer to final!
| # Dockerfile instructions to WORKDIR | ||
| set -eu | ||
|
|
||
| # Apply one-time deferred configuration that relies on ENV variables |
Author
There was a problem hiding this comment.
pinot seems to require absolute paths, which is annoying. https://apache-pinot.slack.com/archives/CDRCA57FC/p1599123680104000
| rootLogger.level=warn | ||
| rootLogger.appenderRefs=stdout | ||
| rootLogger.appenderRef.stdout.ref=STDOUT | ||
| # https://github.com/apache/incubator-pinot/pull/5001 |
Author
There was a problem hiding this comment.
somehow this is not in rc1..
jcchavezs
reviewed
Sep 3, 2020
Author
|
tx @jcchavezs I agree that if we add any non-intuitive special heap arg we should document that |
kotharironak
reviewed
Sep 3, 2020
kotharironak
reviewed
Sep 3, 2020
Author
|
reverted 0.5.0-rc1 as it doesn't have the parallel commit. not sure why rc2 is missing it also |
Author
|
thanks for the look folks. I'll do the schema thing tomorrow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes working with layers immensely easier and prepares for layering schema