Add replication config to server.properties - #4
Merged
Merged
Conversation
ravisingal
requested review from
aaron-steinfeld,
avinashkolluru,
buchi-busireddy,
kotharironak,
laxmanchekka,
surajpuvvada and
tim-mwangi
July 18, 2020 07:57
|
|
||
| {{- if .Values.config.replicaHighWatermarkCheckpointIntervalMs }} | ||
| # The frequency with which the high watermark is saved out to disk | ||
| replica.high.watermark.checkpoint.interval.ms={{ int .Values.config.replicaHighWatermarkCheckpointIntervalMs }} |
There was a problem hiding this comment.
This should long as per Kafka doc. can you check?
Contributor
Author
There was a problem hiding this comment.
int function in helm template convert string to number. It does not differentiate between int and long.
| {{- if .Values.config.replicaLagTimeMaxMs }} | ||
| # If a follower hasn't sent any fetch requests or hasn't consumed up to the leaders log end offset for at least this time, | ||
| # the leader will remove the follower from isr | ||
| replica.lag.time.max.ms={{ int .Values.config.replicaLagTimeMaxMs }} |
There was a problem hiding this comment.
This should also be long, can you check this one too?
kotharironak
approved these changes
Jul 18, 2020
buchi-busireddy
approved these changes
Jul 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.