git actions upgrade + add trivy - #39
Merged
Merged
Conversation
laxmanchekka
requested review from
JBAhire,
aaron-steinfeld,
kotharironak,
ravisingal and
tim-mwangi
as code owners
June 21, 2023 13:24
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
ravisingal
reviewed
Jun 21, 2023
| - name: Run Trivy vulnerability scanner for kafka image | ||
| uses: hypertrace/github-actions/trivy-image-scan@main | ||
| id: trivy-scan-1 | ||
| id: trivy-scan-kafka |
Contributor
There was a problem hiding this comment.
id is not required.
ravisingal
reviewed
Jun 21, 2023
| - name: Run Trivy vulnerability scanner for kafka-zookeeper image | ||
| uses: hypertrace/github-actions/trivy-image-scan@main | ||
| id: trivy-scan-2 | ||
| id: trivy-scan-kafka-zk |
laxmanchekka
commented
Jun 21, 2023
laxmanchekka
commented
Jun 21, 2023
ravisingal
reviewed
Jun 21, 2023
| # TODO: port this similarly to kafka-zookeeper in order to share base layer | ||
| # The only assumption we make about this FROM is that it has a JRE in path | ||
| FROM adoptopenjdk/openjdk11:jre-11.0.18_10@sha256:3282670f5b315c731cb69d62b5d7eb195392be4a55d22a398c9ed1008490de7d | ||
| FROM adoptopenjdk/openjdk11:jre-11.0.19_7@sha256: a2160bc43c40d98324f43260344bf70f3a1d6a408d5dc005d2e6fb4f0f788ec4 |
Contributor
There was a problem hiding this comment.
Suggested change
| FROM adoptopenjdk/openjdk11:jre-11.0.19_7@sha256: a2160bc43c40d98324f43260344bf70f3a1d6a408d5dc005d2e6fb4f0f788ec4 | |
| FROM adoptopenjdk/openjdk11:jre-11.0.19_7@sha256:a2160bc43c40d98324f43260344bf70f3a1d6a408d5dc005d2e6fb4f0f788ec4 |
ravisingal
approved these changes
Jun 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
git actions upgrade + add trivy