optimised docker CI test in GH action - #23
Merged
Merged
Conversation
JBAhire
requested review from
aaron-steinfeld,
buchi-busireddy,
laxmanchekka,
ravisingal and
tim-mwangi
as code owners
December 15, 2020 10:51
aaron-steinfeld
previously approved these changes
Dec 15, 2020
| - name: Checkout Repository | ||
| uses: actions/checkout@v2 | ||
| with: | ||
| fetch-depth: 10 |
Contributor
There was a problem hiding this comment.
Given the comment on the other PR, any reason for this to be 10?
Member
Author
There was a problem hiding this comment.
I guess we discussed this here: hypertrace/attribute-service#43 (comment) so changing this to 0 for now.
Contributor
|
Hmm wonder why the circleci jobs didn't run here |
aaron-steinfeld
approved these changes
Dec 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While trying POC on GitHub action we realised that docker 19.03 and Java 11 are part of runner that comes with Ubuntu-20.04 already has those requirements satisfied. (ref: https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md)
Testing
NA
Documentation