Remove google-cloud-sdk package from docker image. - #2
Merged
Merged
Conversation
ravisingal
requested review from
aaron-steinfeld,
buchi-busireddy,
laxmanchekka,
surajpuvvada and
tim-mwangi
July 13, 2020 10:51
aaron-steinfeld
approved these changes
Jul 13, 2020
tim-mwangi
reviewed
Jul 13, 2020
| buildDeps='curl ca-certificates gnupg dirmngr apt-transport-https'; \ | ||
| buildDeps='curl ca-certificates gnupg dirmngr'; \ | ||
| apt-get update && apt-get install -y $runDeps $buildDeps --no-install-recommends; \ | ||
| echo "deb [signed-by=/usr/share/keyrings/cloud.google.gpg] https://packages.cloud.google.com/apt cloud-sdk main" | tee -a /etc/apt/sources.list.d/google-cloud-sdk.list; \ |
Contributor
There was a problem hiding this comment.
This is not even needed for SaaS, right?
Contributor
Author
There was a problem hiding this comment.
This is need for SaaS. will create a new image for the same. The image size is 726MB and is taking time to fetch it from docker hub. After removing this package, image size is reduced to 278MB.
Contributor
There was a problem hiding this comment.
Ok. Interesting that it is needed for SaaS.
tim-mwangi
approved these changes
Jul 13, 2020
laxmanchekka
approved these changes
Jul 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.