Uses file extension to clarify the install script isn't a directory - #16
Merged
Merged
Conversation
It is normal in UNIX to not add a shell script suffix even if it is common in projects that have both windows and UNIX commands in them. For example, the canonical name for the Docker HEALTHCHECK command is `docker-healthcheck`, not `docker-healthcheck.sh`. There's a special case @jcchavezs noticed when looking at how the installation layer is setup. The word `install` is both used for a root directory `/install` and also a script that populates that, `/tmp/install`. This distracted him from other work and that's an anti-goal. Instead of deciding a different name for `/install` or a different name for the `/tmp/install` script, this appends an otherwise unnecessary `.sh` to the install script to avoid the problem without creating a new naming problem.
codefromthecrypt
requested review from
aaron-steinfeld,
buchi-busireddy,
laxmanchekka,
ravisingal and
tim-mwangi
as code owners
September 11, 2020 01:46
tim-mwangi
approved these changes
Sep 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is normal in UNIX to not add a shell script suffix even if it is
common in projects that have both windows and UNIX commands in them.
For example, the canonical name for the Docker HEALTHCHECK command is
docker-healthcheck, notdocker-healthcheck.sh.There's a special case @jcchavezs noticed when looking at how the
installation layer is setup. The word
installis both used for aroot directory
/installand also a script that populates that,/tmp/install. This distracted him from other work and that's ananti-goal.
Instead of deciding a different name for
/installor a differentname for the
/tmp/installscript, this appends an otherwiseunnecessary
.shto the install script to avoid the problem withoutcreating a new naming problem.